nrf_wifi: Fix TX de-init crash #1277
Merged
+46
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krish2718
requested review from
sachinthegreen,
rado17 and
rlubos
as code owners
krish2718
force-pushed
the
fix_deinit_crash
branch
from
9b5bcdc
to
1d863e8
Compare
krish2718
force-pushed
the
fix_deinit_crash
branch
from
1d863e8
to
8cb9056
Compare
sachinthegreen
approved these changes
May 31, 2024
Interrupts should be disabled early to avoid further events coming up the driver. Signed-off-by: Chaitanya Tata <[email protected]>
The HAL status is used internally, but the API was never called, so, hook up the API to dev init/deinit. Signed-off-by: Chaitanya Tata <[email protected]>
Draining should be done early to avoid any event handlers being called after, also, remove the check for HAL status, as drain doesn't invoke the event handlers, this fixes the memory leak. Signed-off-by: Chaitanya Tata <[email protected]>
Use the unused HAL de-init API before proceeding with FMAC de-init, this way we can move the entire logic and locking to HAL de-init, so, remove the HAL locks in FMAC. Signed-off-by: Chaitanya Tata <[email protected]>
In current SAP implementation based on a single VIF, we modify the VIF type from STA->AP and vice-versa, so, call the API to update the counts properly. The counts are crucial to remove the RPU during interface down. Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
force-pushed
the
fix_deinit_crash
branch
from
d28b464
to
f4ec455
Compare
rado17
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If interface is de-initialized during active traffic, then the HAL RX lock still doesn't protect the full de-initialization path, there is a race after TX de-init, lock is released and before the FMAC context is de-initialized the NULL checks elsewhere pass and can lead to crashes.
Add an atomic API that does both de-initialization and removal by taking the HAL RX lock for both operations, this way FMAC context is freed and NULL checks should avoid any crashes.
Fixes SHEL-2436.